Merged
Conversation
blt
force-pushed
the
blt/memory-stats-payloadtools
branch
from
36b2441 to
df55fee
Compare
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This commit updates payloadtool with a tracking allocator, showing: * total allocations * total deallocations * total bytes allocated * peak bytes live This information is exposed on stderr if `--memory-stats` is provided to payloadtool. The goal is to enable more convenient optimization flows for lading developers. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/memory-stats-payloadtools
branch
from
df55fee to
226040d
Compare
GeorgeHahn
reviewed
Jan 14, 2026
| #![allow(clippy::print_stdout)] | ||
| #![allow(clippy::print_stderr)] | ||
|
|
||
| /// Memory allocation tracking for payloadtool statistics. |
Contributor
There was a problem hiding this comment.
Could dhat-rs be used instead? Here's an example usage in saluki
Collaborator
Author
There was a problem hiding this comment.
I will merge this as-is and then explore dhat-rs in a follow-up.
GeorgeHahn
approved these changes
Jan 14, 2026
Contributor
GeorgeHahn
left a comment
GeorgeHahn
left a comment
There was a problem hiding this comment.
Noted a big possible change, but lgtm with or without that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit updates payloadtool with a tracking allocator, showing:
This information is exposed on stderr if
--memory-statsis provided to payloadtool. The goal is to enable more convenient optimization flows for lading developers.